Skip to content

Commit

Permalink
Drop Python 3.8 (#808)
Browse files Browse the repository at this point in the history
* Drop Python 3.8

* Update changelog.

* Update package metadata

* Remove Python 3.8-specific code.
  • Loading branch information
danielballan authored Nov 1, 2024
1 parent d1ca0bf commit c1ff4c9
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 2,619 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ jobs:
strategy:
matrix:
python-version:
- "3.8"
- "3.9"
- "3.10"
- "3.11"
Expand Down
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,16 @@ Write the date in place of the "Unreleased" in the case a new version is release

## Unreleased

### Added

- Add adapters for reading back assets with the image/jpeg and
multipart/related;type=image/jpeg mimetypes.

### Changed

- Drop support for Python 3.8, which is reached end of life
upstream on 7 October 2024.

## v0.1.0b10 (2024-10-11)

- Add kwarg to client logout to auto-clear default identity.
Expand Down
4 changes: 1 addition & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ authors = [
maintainers = [
{ name = "Brookhaven National Laboratory", email = "[email protected]" },
]
requires-python = ">=3.8"
requires-python = ">=3.9"

# All dependencies are optional; it depends on whether you are running
# a client or server (or both) and what data structures you care about.
Expand All @@ -23,8 +23,6 @@ classifiers = [
"Development Status :: 4 - Beta",
"License :: OSI Approved :: BSD License",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Expand Down
6 changes: 1 addition & 5 deletions tiled/client/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,7 @@ def sync_clear_token(self, key):
with self._sync_lock:
self.tokens.pop(key, None)
filepath = self.token_directory / key
# filepath.unlink(missing_ok=False) # Python 3.8+
try:
filepath.unlink()
except FileNotFoundError:
pass
filepath.unlink(missing_ok=False)
self.tokens.pop(key, None) # Clear cached value.

def sync_auth_flow(self, request, attempt=0):
Expand Down
Loading

0 comments on commit c1ff4c9

Please sign in to comment.