Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: small refactoring changes to CSV adapter #803

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

MNT: small refactoring changes to CSV adapter #803

wants to merge 29 commits into from

Conversation

genematx
Copy link
Contributor

@genematx genematx commented Oct 29, 2024 •
edited
Loading

  • Allow CSVAdapter to accept kwargs for pd.read_csv
  • Remove dataframe_adapter property from CSVAdapter
  • Allow simple instantiation with either single uri or a list of uris
  • Specify multipart/related;type=text/csv mimetype
  • Add docstrings

Checklist

  • Add a Changelog entry
  • Add the ticket number which this PR closes to the comment section

jwlodek and others added 16 commits October 15, 2024 13:18
@genematx genematx marked this pull request as ready for review October 29, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skarakuzu skarakuzu Awaiting requested review from skarakuzu

@danielballan danielballan Awaiting requested review from danielballan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@genematx @jwlodek