Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toastnotification when an app requests root #803

Open
4mede opened this issue Nov 25, 2024 · 5 comments
Open

Toastnotification when an app requests root #803

4mede opened this issue Nov 25, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@4mede
Copy link

4mede commented Nov 25, 2024

Is your feature request related to a problem?/你的请求是否与某个问题相关?

No.

Describe the solution you'd like/描述你想要的解决方案

I think Magisk implements this well. Ideally, users would be able to choose notifications, toasts, or nothing like on Magisk. Even if it's not on by default, I think it would be better than not having the option at all. For security reasons and so that new users know that they have to go to the app to enable superuser for an app to use root, I think this would be helpful.

Describe alternatives you've considered/描述您考虑过的备选方案

None.

Additional context/其他信息

No response

@4mede 4mede added the enhancement New feature or request label Nov 25, 2024
@VisionR1
Copy link
Contributor

Not have this option because like you write, go to the app to enable superuser for an app to use root, for that not have request root, so I think is not very useful option like that, because already we know in which app give root.

@4mede
Copy link
Author

4mede commented Nov 25, 2024

Yes, but it's helpful to know when an app is using root and when an app that doesn't have it requests it. What if an app is using root and you don't want it to? What if an app is using it in the background all the time and so you want to revoke its permission? You won't know if there's no toast. What if there's a bypass like this and an app gets root permission without you authorizing it?

@VisionR1
Copy link
Contributor

Yes, but it's helpful to know when an app is using root and when an app that doesn't have it requests it. What if an app is using root and you don't want it to? What if an app is using it in the background all the time and so you want to revoke its permission? You won't know if there's no toast. What if there's a bypass like this and an app gets root permission without you authorizing it?

Yeah, I get your point.
I think this have fixed in latest Magisk, I don't know about APatch.

@4mede
Copy link
Author

4mede commented Nov 25, 2024

Yes, it's fixed, and I wasn't saying it applies to APatch. But a similar vulnerability could be found in APatch.

@VisionR1
Copy link
Contributor

Yes, it's fixed, and I wasn't saying it applies to APatch. But a similar vulnerability could be found in APatch.

Yeah, understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants