Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keses mertekenek jelzese #98

Open
lordblendi opened this issue Oct 18, 2017 · 0 comments
Open

Keses mertekenek jelzese #98

lordblendi opened this issue Oct 18, 2017 · 0 comments

Comments

@lordblendi
Copy link
Member

lordblendi commented Oct 18, 2017

A kesest jelenleg orakban szamoljuk a moment.js segitsegevel itt:
https://github.com/bme-db-lab/szglab5-frontend/blob/master/app/models/deliverable.js#L40
Jo lenne, ha ora es perc is megjelenne, hisz <1 ora eseten, csak 0 ora jelenik meg, ami nem egyertelmu.

Viszont az ora / hours szavak nem a computed property reszei.
student: https://github.com/bme-db-lab/szglab5-frontend/blob/master/app/templates/components/student-laboratory-upload.hbs#L29
Demonstrator: https://github.com/bme-db-lab/szglab5-frontend/blob/master/app/templates/components/demonstrator-student.hbs#L85
Evaluator: https://github.com/bme-db-lab/szglab5-frontend/blob/master/app/templates/evaluator.hbs#L154

Emiatt javaslom, hogy az ember computed adjon vissza egy objectet, es a megfelelo nyelvet jelenitsuk meg a megfelelo feluleten:

{
 'en': '3 hours 1 minutes',
 ' hu': '3 óra 2 perc'
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants