Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace regex in Str::placeholders (#37) #38

Open
wants to merge 2 commits into
base: 3.0
Choose a base branch
from

Conversation

Spidlace
Copy link

Related to #37

Fix issue

@Spidlace Spidlace changed the title Replace regex in Str::placeholders (#37) Replace regex in Str::placeholders (#37) May 22, 2021
@bobdenotter
Copy link
Member

Hi, @Spidlace,

If we merge this in, as-is, won't it break the behaviour that we currently use in things like title_format: "{name} - {id}" ?

@Spidlace
Copy link
Author

Hi @bobdenotter

Sorry I didn't seen your answer
I push new commit :

  • I add optional bracket in regexp
  • I put char in lowercase by default

And I can confirm, everythings works well with boltform (replyto_name and email) and with bolt core (when we create new page, or select fields for example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants