Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbolic link does not work in docker #62

Open
ionutlip opened this issue Feb 9, 2021 · 2 comments
Open

Symbolic link does not work in docker #62

ionutlip opened this issue Feb 9, 2021 · 2 comments

Comments

@ionutlip
Copy link

ionutlip commented Feb 9, 2021

Hi @toofff,
Following the discussion on the slack with this change from composer.json
"assets:install --symlink --relative %PUBLIC_DIR%": "symfony-cmd" => "assets:install %PUBLIC_DIR%": "symfony-cmd"
everything is ok, so it looks like it can't be used "--symlink --relative" for symfony assets

Thanks @toofff for help

@toofff
Copy link
Contributor

toofff commented Feb 9, 2021

For me there are 2 problems.

1/ why we can't get a symbolic link in the Docker environment.
The latest Symfony installations with flex no longer highlight the installation of assets with a symbolic link, maybe the same thing should be done?

2/ why is it up to the "Bolt/Core" component to carry the commands that must be launched by composer during installation and update events?

In Symfony, the developer is free to configure his own composer scripts. With flex, each time a new component is installed, this part is updated, when the flex recipe is available, its scripts risk causing us problems.

At first it would be better to put all the scripts as they were before.

@ionutlip
Copy link
Author

ionutlip commented Feb 9, 2021

  1. yes you are right, I think the same thing needs to be done
  2. yes, the developer should be free to make the necessary changes to his project

@ionutlip ionutlip closed this as completed Feb 9, 2021
@ionutlip ionutlip reopened this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants