Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github actions to use non-deprecated actions #344

Closed
1 task
marsella opened this issue May 4, 2023 · 3 comments · Fixed by #431
Closed
1 task

Update github actions to use non-deprecated actions #344

marsella opened this issue May 4, 2023 · 3 comments · Fixed by #431

Comments

@marsella
Copy link

marsella commented May 4, 2023

The actions-rs/toolchain action we use to install Rust in our CI is not maintained and uses features that are being deprecated "very soon" by Github Actions. We should try to remove this dependency so we don't get caught off-guard if it stops working.

There's quite a bit of discussion online about alternative options. They include

  • dtolnay/rust-toolchain/: a different, maintained action that does the same thing. I think it's best for "caching toolchains that are not installed directly" on the github action server images
  • manually updating Rust: I guess the server images used for Github Actions already have Rust installed, so you don't have to go through an action

I'm not sure which of these has better caching behavior, but they both seem reasonable to me.

Similarly, actions-rs/cargo is not maintained but it seems like we shouldn't need to use a whole action for that.

Closing criteria

  • Update CI to (a) work and (b) not throw a bunch of warnings
@LordQ1
Copy link

LordQ1 commented May 5, 2023

Duplicated over to https://app.zenhub.com/workspaces/bolt-team-60886be9e01f13000e361d92/issues/gh/boltlabs-inc/maestro/330 for working; hopefully you will copy the fix.

@marsella
Copy link
Author

Copy-able fix in https://github.com/boltlabs-inc/maestro/pull/366

@marsella
Copy link
Author

marsella commented Jun 5, 2023

Noting: this should be done by someone internal to Bolt who has access to that repo, and not by a contractor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants