Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rust version to 1.70 #313 #431

Merged
merged 11 commits into from
Jun 22, 2023
Merged

update rust version to 1.70 #313 #431

merged 11 commits into from
Jun 22, 2023

Conversation

marsella
Copy link

@marsella marsella commented Jun 21, 2023

Closes #313.
Closes #344.

This uses a different paradigm for updating github actions than elsewhere in the company. It also has the benefit of reducing CI times by 2-3 minutes due to the different installer for cargo-make, and by ~8ish minutes when the rust toolchains are correctly cached!

@marsella marsella requested a review from hridambasu June 21, 2023 19:10
@marsella marsella requested a review from gatoWololo June 21, 2023 21:02
Copy link

@gatoWololo gatoWololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link

@hridambasu hridambasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@marsella marsella merged commit 421a7a5 into main Jun 22, 2023
@marsella marsella deleted the 313-update-rust branch June 22, 2023 12:58
@marsella marsella mentioned this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update github actions to use non-deprecated actions Update Rust to version 1.70
3 participants