New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review comments on Tezos API #256

Open

yaymukund opened this issue Sep 30, 2021 · 1 comment

Contributor

yaymukund commented Sep 30, 2021

The code was moving fast, and we may have missed updating some of them.

Specifically:

The verifications were once meant to wait for the on chain state to update, but now we expect things to be correct at HEAD.
The 'confirmation depth' code has changed.
We changed the protocol so the customer waits for the merchant to perform a verification before funding the contract.
Variable names may have changed.

Contributor

marsella commented Jan 10, 2022

See also: #335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment