Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ChannelId to have a canonical representation #300

Open
marsella opened this issue Oct 26, 2021 · 0 comments
Open

Update ChannelId to have a canonical representation #300

marsella opened this issue Oct 26, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@marsella
Copy link
Contributor

marsella commented Oct 26, 2021 •
edited
Loading

The channel ID currently has two representations: as a [u8; 32] and as a Scalar. These representations do not have a bijective relationship -- there are more byte arrays than scalars.

We should make sure that the representation that is serialized, displayed, and stored in databases is not ambiguous.

I think there is not an operational bug related to this, but printing it out (Display) sometimes shows a different value than the serialized version.
@marsella marsella added the bug Something isn't working label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marsella