Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test malicious-customer pay scenarios #327

Open
1 task
marsella opened this issue Nov 16, 2021 · 1 comment
Open
1 task

Test malicious-customer pay scenarios #327

marsella opened this issue Nov 16, 2021 · 1 comment

Comments

@marsella
Copy link
Contributor

We need to test scenarios with properly malicious customer, e.g. one who does not use our lovely, misuse-resistant API.

Consider the following scenarios:

  • A malicious customer tries to pay on a closed channel. They form a pay request on a state that has already been closed (zeekoe does not stop them).
  • A malicious customer tries to pay on a channel using an outdated state

In both these cases, the merchant must reject the payment with a ReusedRevocationLock error.

To implement this (and other malicious-party tests), we need to implement a party that adheres to the protocol flow but behaves incorrectly.

  • Discuss possible architectures for implementing these tests
@indomitableSwan
Copy link

Just a quick note that we should make sure to test all close methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants