Bookie tests failing; need to fix installation for Travis CI #34
Comments
|
@craigmaloney Can you give me some info about breadability/bookie? My story is that I use breadability in https://github.com/miso-belica/sumy and did some changes into in the past. It's quite a while :) From my point of view I guess we could remove support for old Py2.6 if possible or maybe even Py3.3. But I am not sure about it. I can live with it in sumy. Also I would refactor tests to run using pytest and I would remove unittest2 package then if possible. I can see there is some old branch What do you think? |
|
I was speaking on the project as a whole. I don't think the current batch of tests can be run on breadability by itself. I hate to say the word "fork" but I'm wondering if it's time to fork off breadability on its own until if / when Bookie can be modernized. Are you currently maintaining a branch? |
|
Hmm, sorry, but I don't use bookie and I don't even know what exactly it is. I always though some kind of Readability app fork? But I don't see how breadability fork help here. If problem is somewhere else in bookie stack I think it should be fixed there. I believe breadability can be fixed right here. I can help with porting to pytest and fix the failing tests if dropping py2.6 support is not option and someone will do me a review, but I don't think I can help with other bookie packages. If you can write how breadability is blocking some other package to upgrade maybe I can fix also that issue, but that's all. |
|
breadability was/is an open source bookmark management app and breadabilty
was a python port of the open version of the readability JS code long ago
so that we could load the web page content for searching when you
bookmarked something.
Definitely don't worry about bookie with breadability updates and I'm happy
to help test/review any changes that make it work. No need for py2 support
or the like. I'd started to port all my own stuff to pytest and am a fan so
any changes there are welcome as well.
…On Tue, Mar 27, 2018 at 1:41 PM Mišo Belica ***@***.***> wrote:
Hmm, sorry, but I don't use bookie and I don't even know what exactly it
is. I always though some kind of Readability app fork? But I don't see how
breadability fork help here. If problem is somewhere else in bookie stack I
think it should be fixed there. I believe breadability can be fixed right
here.
I can help with porting to pytest and fix the failing tests if dropping
py2.6 support is not option and someone will do me a review, but I don't
think I can help with other bookie packages. If you can write how
breadability is blocking some other package to upgrade maybe I can fix also
that issue, but that's all.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEoi6_JzsLJRvqiJ38xOPHptNnLWyJhks5tinmygaJpZM4S3T2D>
.
|
|
sorry, bookie was/is an open source bookmark app. breadability was just a
library put together for it.
…On Tue, Mar 27, 2018 at 1:44 PM Rick Harding ***@***.***> wrote:
breadability was/is an open source bookmark management app and breadabilty
was a python port of the open version of the readability JS code long ago
so that we could load the web page content for searching when you
bookmarked something.
Definitely don't worry about bookie with breadability updates and I'm
happy to help test/review any changes that make it work. No need for py2
support or the like. I'd started to port all my own stuff to pytest and am
a fan so any changes there are welcome as well.
On Tue, Mar 27, 2018 at 1:41 PM Mišo Belica ***@***.***>
wrote:
> Hmm, sorry, but I don't use bookie and I don't even know what exactly it
> is. I always though some kind of Readability app fork? But I don't see how
> breadability fork help here. If problem is somewhere else in bookie stack I
> think it should be fixed there. I believe breadability can be fixed right
> here.
>
> I can help with porting to pytest and fix the failing tests if dropping
> py2.6 support is not option and someone will do me a review, but I don't
> think I can help with other bookie packages. If you can write how
> breadability is blocking some other package to upgrade maybe I can fix also
> that issue, but that's all.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#34 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAEoi6_JzsLJRvqiJ38xOPHptNnLWyJhks5tinmygaJpZM4S3T2D>
> .
>
|
@miso-belica pointed out that the tests for Bookie are failing. That's part of the issue. The other part is that Bookie is not currently able to build because certain packages have aged out and are no longer available. I don't remember the specifics at the moment so I can't elaborate more without re-trying the build process. What I remember though is I got stuck while trying to modernize the packages with later versions.
The text was updated successfully, but these errors were encountered: