FIX: avoid overflow on overflow check in toms748_solve safe_div #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2023
mborland
reviewed
Feb 4, 2023
| @@ -160,7 +160,8 @@ inline T safe_div(T num, T denom, T r) | |||
|
|
|||
| if(fabs(denom) < 1) | |||
| { | |||
| if(fabs(denom * tools::max_value<T>()) <= fabs(num)) | |||
| constexpr T inv_max_value = 1.0 / tools::max_value<T>(); | |||
There was a problem hiding this comment.
Suggested change
| constexpr T inv_max_value = 1.0 / tools::max_value<T>(); | |
| const T inv_max_value = 1.0 / tools::max_value<T>(); |
As @jzmaddock noted in #942 we still need to support types that don't have constexpr construction.
There was a problem hiding this comment.
Even better make that static const and then it's evaluated just the once.
mckib2
force-pushed
the
toms748-solve-mac-m1-overflow-fix
branch
from
3cf46ad
to
9b0a6be
Compare
|
Superceded by #945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[number]*tools::max_value<T>()to prevent overflows on Apple M1 processors