Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computation of the resulting static shape for the general tensor multiplication is not correct #111

Open
bassoy opened this issue Apr 29, 2021 · 0 comments
Open

Computation of the resulting static shape for the general tensor multiplication is not correct #111

bassoy opened this issue Apr 29, 2021 · 0 comments
Assignees
@bassoy @amitsingh19975
Labels
bug

Comments

@bassoy
Copy link
Collaborator

bassoy commented Apr 29, 2021

Lambda function

ublas/include/boost/numeric/ublas/tensor/functions.hpp

Line 359 in 32795e1

auto extents_result = [&e1 = na, &e2 = nb, &a1 = phia, &a2 = phib](){

performs a wrong computation of the resulting static shape invoked in line

ublas/examples/tensor/multiply_tensors_product_function.cpp

Line 312 in 32795e1

// auto C1 = C + prod(A,A,perm_t{1,2}) + 5.0F;

@bassoy bassoy added the bug label Apr 29, 2021
amitsingh19975 added a commit that referenced this issue Apr 29, 2021
@amitsingh19975
FIX: fix the issue #111
eb08923 
This bug occured because the type extent_of_rank_one_array_v was
bool instead of std::size_t, which in turn casting the std::size_t
value into bool. If the size of the array was N, it would cast it
into 1.
@amitsingh19975 amitsingh19975 mentioned this issue Apr 29, 2021
Closed
@bassoy bassoy mentioned this issue May 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassoy bassoy

@amitsingh19975 amitsingh19975

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bassoy @amitsingh19975