Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of Template Type in the Wrong Place #124

Open
amitsingh19975 opened this issue Jun 4, 2021 · 4 comments
Open

Use of Template Type in the Wrong Place #124

amitsingh19975 opened this issue Jun 4, 2021 · 4 comments
Assignees
Labels

Comments

@amitsingh19975
Copy link
Collaborator

The template type, which is used for the type of extents harder coded to std::size_t instead of using the template type provided by the user. The user-provided type is misused to define the size of the static rank extents.

Link to the bug.

Fix:

template <integral T, T N>
class extents_core<T,N> {
public:  
       using base_type       = std::array<T,N>;
....
}
@shivamt2
Copy link

Hi, I would like to work on this.

@amitsingh19975
Copy link
Collaborator Author

Go ahead.

@Neel-Shah-29
Copy link
Contributor

Can I try to solve this issue? Also guide me once through the issue that we need to replace std::size_t to the template type provided by the user in all the files right?

@amitsingh19975
Copy link
Collaborator Author

Can I try to solve this issue? Also guide me once through the issue that we need to replace std::size_t to the template type provided by the user in all the files right?

It will be fixed with the bug fix for the extents. So, there's no need for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants