Features/tensor redesign #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix all clang-tidy warnings * Update clangtidy_check.yml * Do not run review for PR from forks In order to run review from forks we need to create a Github bot that has full access to all forks and can perform review even from forks. * Update clangtidy_review.yml * Update clangtidy_review.yml
* Fix all clang-tidy warnings * Update clangtidy_check.yml * Do not run review for PR from forks In order to run review from forks we need to create a Github bot that has full access to all forks and can perform review even from forks. * Update clangtidy_review.yml * Update clangtidy_review.yml
…ts_functions.hpp with function implementation
* [skip ci] Add "cxxstd" json field. The "cxxstd" json field is being added to each Boost library's meta json information for libraries in order to specify the minumum C++ standard compilation level. The value of this field matches one of the values for 'cxxstd' in Boost.Build. The purpose of doing this is to provide information for the Boost website documentation for each library which will specify the minimum C++ standard compilation that an end-user must employ in order to use the particular library. This will aid end-users who want to know if they can successfully use a Boost library based on their C++ compiler's compilation level, without having to search the library's documentation to find this out. * Updated the minimum C++ standard requirement to C++11 based on the Ublas Wiki section mentioning C++11 as a prerequisite.
This bug occured because the type extent_of_rank_one_array_v was bool instead of std::size_t, which in turn casting the std::size_t value into bool. If the size of the array was N, it would cast it into 1.
|
This Pull request Passed all of clang-tidy tests. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #111, where the fixed rank extents were producing the wrong shape tensor. This bug arises due to the wrong type of the trait
extent_of_rank_one_array_vwas declared, where instead ofstd::size_t, the type declared was bool. Therefore, whenever the sizeNwas inferred, the size cast into a bool, either 0 or 1.