feat: add names to all events and functions signatures inputs

[sammccord]

Description

Frontend needs to show detailed info about action steps. They have the signature, and @boostxyz/signatures to get the event/function name, but would need names for individual inputs to both help users create boosts, and our devs to build richer ui.

Suggested Solution

Add names to all events and functions in boost-protocol/packages/signatures/manifests

ie
Transfer(address indexed,address indexed,uint256 indexed)
becomes
Transfer(address indexed from,address indexed to,uint256 indexed amount)

[Quazia]

This will cause args to get returned as K:V pairs instead of an array - they're unnamed for internal use intentionally. We could maintain both or maintain the named list and employ a helper to strip out the names. This is related to the signatures ergonomics work @topocount was going to focus on next. The ask here is basically that we need to serve the event as a human readable ABI with params in some way right?

[Quazia]

Another somewhat related thing I noticed recently too is there are some issues if we have the same event selector but the configuration of what is indexed is different - i.e. Transfer(address indexed,address indexed,uint256 indexed) vs Transfer(address indexed,address indexed,uint256)

[topocount]

@Quazia We have a ticket for that isssue with indexed vs nonindexed args here: https://linear.app/rh-app/issue/BOOST-4764/modify-the-eventaction-validators-to-account-for-indexed-args-through

[sammccord]

This will cause args to get returned as K:V pairs instead of an array - they're unnamed for internal use intentionally. We could maintain both or maintain the named list and employ a helper to strip out the names. This is related to the signatures ergonomics work @topocount was going to focus on next. The ask here is basically that we need to serve the event as a human readable ABI with params in some way right?

Yeah, Boost detail designs, and create flow rely on input names to label actions to be less error-prone and make the ui richer.

[topocount]

@sammccord this needs to be downstream of the work on signature package eronomics, as it'll break EventAction right now.

[soulstar9792]

May I ask if the new-comers work for a paid position?

[sammccord]

May I ask if the new-comers work for a paid position?

@soulstar9792 Thanks for inquiring. We are not currently hiring freelance contributors without prior history of contributions to the repository.