Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance error messaging for failed clawbackFromTarget #282

Open
mmackz opened this issue Nov 19, 2024 · 0 comments
Open

feat: enhance error messaging for failed clawbackFromTarget #282

mmackz opened this issue Nov 19, 2024 · 0 comments

Comments

@mmackz
Copy link
Contributor

mmackz commented Nov 19, 2024

Description

Currently it is hard to tell why an incentive clawback has failed. It simply returns a clamFailed error, which is not the most helpful.

Suggested Solution

Ideally we would have more descriptive error messages to let you know why the clawback failed. For example, the ERC20Incentive will fail if the amount passed in is not an exact multiple of the reward value.

It can also fail if you do not pass in the correct target address (which should be core in most cases?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant