Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we panic here? #295

Closed
github-actions bot opened this issue Apr 13, 2024 · 0 comments · Fixed by #366
Closed

should we panic here? #295

github-actions bot opened this issue Apr 13, 2024 · 0 comments · Fixed by #366
Assignees
Labels

Comments

@github-actions
Copy link
Contributor

should we panic here?

// XXX: should we panic here?

Source of this issue
				             .get(name)
				             .map(Cow::from)
				             .or_else(|| std::env::var(name).map_err(log_err).ok().map(Cow::from))
				             .unwrap_or_else(|| {
					             // XXX: should we panic here?
					             panic!("Env var \"{name}\" not found")
				             });

				replaced = replaced.replace(full, &var);
			}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant