Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release scala 2.13 version #103

Closed
domdorn opened this issue Apr 4, 2021 · 6 comments
Closed

Release scala 2.13 version #103

domdorn opened this issue Apr 4, 2021 · 6 comments
Labels
Milestone

Comments

@domdorn
Copy link

domdorn commented Apr 4, 2021

Cause of free time over eastern, I came across an old proof of concept bot of mine made with this library. I wanted to update it to the newest versions of akka, scala etc. and noticed this lib is still on 2.12.

It looks like you've already done what is necessary to run the code in 2.13, so what is left is just publishing the artifacts for 2.13.

If this is true, I'd appreciate it if you could publish them!

Thanks,
Dominik

@ex0ns
Copy link
Contributor

ex0ns commented Apr 4, 2021

Hello
I've published a snapshot release while we are updating the lib to support the latest changes in Telegram's API
This is a snapshot release so you might need to tweak your build.sc a bit

import coursier.maven.MavenRepository

object core extends ScalaModule {
  def scalaVersion = "2.13.4"

  def repositories = super.repositories ++ Seq(
    MavenRepository("https://oss.sonatype.org/content/repositories/snapshots")
  )
  def ivyDeps = Agg(
    ivy"com.bot4s::telegram-core:5.0.0-SNAPSHOT"
  )
}

Please note that support for Scala.js and Scala 2.11 were drop in this release (Scala.js is on my todo list, but 2.13 was more important IMO), support for akka should be ok, but I did not test it thoroughly yet (I mostly tested the jvm polling setup).

I am planning to do a release candidate soon, but I would like make some changes first as this will introduces some breaking changes (tokens are not supported anymore in Scala, are deprecated and will be removed in the next version).

I'll keep this issue open to keep track of the releases up until 5.0.0

Thanks

@domdorn
Copy link
Author

domdorn commented Apr 4, 2021

wow, thanks for the quick reply!
I've just updated my dependencies and will try to get the code running again.
I've also saw that you use the tagless final pattern. After the code works, I'll try to get it running
with zio as well to see how it goes and can keep u posted if u want!
thanks again!

@ex0ns
Copy link
Contributor

ex0ns commented Apr 4, 2021

That should be possible to get it running with ZIO, at least some part of it.
I wanted to try that a few weeks ago but go distracted with all the update that had to be done on the library, I would definitely be interested it you make it run with ZIO

@domdorn
Copy link
Author

domdorn commented Apr 4, 2021

I got it running with ZIO... will do some cleanups and then send you a link to a repo.
are you going to upgrade to sttp 3 as well or stay with sttp 2 ?

@ex0ns
Copy link
Contributor

ex0ns commented Apr 5, 2021

Nice !
I will love to move to sttp3, this is also something I would like to do before the next release. I haven't had too much issue migrating from sttp2 to sttp3 on other project and I will be working on that pretty soon, but I don't have a estimated date for the release yet

@ex0ns ex0ns added this to the 5.0.0 milestone Apr 5, 2021
@ex0ns ex0ns added the question label Apr 5, 2021
@domdorn
Copy link
Author

domdorn commented Apr 5, 2021

@ex0ns ex0ns closed this as completed Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants