Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for multi-task training #73

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ozgurozdemir
Copy link

  • TASK_INFO and use_textual_output are added for tr_datasets.py
  • dataset_processor is modified to accept list of dataset names.
  • EvaluatorForConditionalGeneration.compute_metrics is updated for multi-task configuration.

Copy link
Contributor

@gokceuludogan gokceuludogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your significant contributions. I have a few suggestions:

  • Instead of adding use_textual_output to each dataset individually, we should consider implementing it directly in BaseDataset since it's a common feature across all datasets.
  • The term use_textual_output might not be clear. Perhaps renaming it to task_prefix could provide more clarity.
  • For allowing testing, it would be great to add configuration options for multitask training in conf and refactor the existing finetune.py and eval.py scripts or consider implementing new ones.
  • Finally, adding a tutorial on multitask training in our documentation would greatly benefit our users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants