Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.2.3 still includes Android Support Library Annotations in POM #432

Open
4 tasks done
ashughes opened this issue Aug 23, 2020 · 2 comments
Open
4 tasks done
Assignees
Labels

Comments

@ashughes
Copy link

Description of the Issue

This repo has already been completely migrated to AndroidX, however, the artifact for release 4.2.3 still includes the Android Support Library Annotations as a dependency in the POM. This causes the Android Support Library Annotations to be included as a transitive dependency for any projects that use the Box SDK (which prevents disabling the Jetifier).

Steps to Reproduce

  1. Add implementation 'com.box:box-android-sdk:4.2.3' to a sample project that uses only AndroidX dependencies.
  2. Add Can I drop Jetifier? to the sample project.
  3. Run ./gradlew -Pandroid.enableJetifier=false canIDropJetifier

Expected Behavior

This should output No dependencies on old artifacts! Safe to drop Jetifier.

Error Message

Instead this outputs:

Cannot drop Jetifier due to following external dependencies:

* com.box:box-android-sdk:4.2.3
  \-- com.android.support:support-annotations:26.1.0

Versions Used

Android SDK: 29
Android: 10

@ashughes
Copy link
Author

ashughes commented Aug 23, 2020

FYI, I ran Can I drop Jetifier? on this repo and got the following output:

> Task :box-content-sample:canIDropJetifier
========================================
Project box-content-sample
========================================

No dependencies on old artifacts! Safe to drop Jetifier.


> Task :box-content-sdk:canIDropJetifier
========================================
Project box-content-sdk
========================================

No dependencies on old artifacts! Safe to drop Jetifier.

So just confirming that the repo itself doesn't have any Android Support Library references and the issue is just with the POM in the artifact.

This also means you can remove android.enableJetifier=true from gradle.properties in this repo. I created PR #433 to do this.

@guillaume-tgl
Copy link

Can you please fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants