Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen button works but fullscreen-box does not when run on a port #116

Open
rigdern opened this issue Aug 1, 2024 · 0 comments
Open

Comments

@rigdern
Copy link

rigdern commented Aug 1, 2024

Repro steps

I reproed this with Boxer 3.4.19 2024-06-24

  1. Download, unzip, and open fullscreen-box port demo.box.zip
  2. Click on child2 to view the box fullscreen
  3. Run the line marked with run-me:. It calls fullscreen-box on a port to child1.useful-box

Expected result: fullscreen-box makes the port fullscreen just like what happens when I click on the port's top-right corner.

Unexpected result: fullscreen-box returns a Boxer error:

Error: RESIZE-ERROR
Primitive FULLSCREEN-BOX
You Can only Zoom Visible Editor boxes

Screenshot of child2 from the repro file:
image

Use case

Suppose you have a box of common utilities that you keep at the root of your project. Suppose you're currently working several boxes down from that and you just built a new utility that you think will be useful to add to the common utilities. With this capability, you can do something like fullscreen-box port-to root-box (maybe even wire this up to a hotkey). When you're done adding the utility, you just close the box and you're back to where you were working.

An approach to achieve the same thing that works now is to get a port to the root box and then make it fullscreen by clicking on its top-right corner.

These workflows have an advantage over manually navigating to the root box. The downside of this workflow is that when you're done adding the common utility, you've lost the position where you were working. So this workflow has a higher context switching cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant