Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User feedback #202

Open
3 of 5 tasks
marvinhagemeister opened this issue Aug 2, 2020 · 0 comments
Open
3 of 5 tasks

User feedback #202

marvinhagemeister opened this issue Aug 2, 2020 · 0 comments

Comments

@marvinhagemeister
Copy link
Collaborator

marvinhagemeister commented Aug 2, 2020

Just gave a few colleagues from Preact an introduction into pentf and here is some first feedback (in no particular order):

Critique:

  • Confused that there isn't a proper cli binary - Add proper CLI binary #203
    • No need for program description
    • Root dir is always __dirname/process.cwd() in all projects
    • Suggestion to be able to pass glob pattern directly
  • Creating tests is very verbose compared to a quick it() call in other frameworks - Suite API #201
    • Lack of suite API, most test cases are only a couple of lines
    • Manually having to pass the type of config
  • No native ESM support. The CJS interop in node is okay, but not really nice to use. It doesn't support named exports from commonjs - Add native ES Modules build target #219
  • Confused by default viewport of 800x600px
    • Were expecting it to work the other way around: By default it's fluid and if tests need a specific resolution they should set that.
  • Submodule imports were perceived as awkward to use with TS/JSDoc

Neutral:

  • No watch mode
  • Took a bit of time to adjust thinking away from closure sharing that's common in other frameworks

Positive:

  • Ability to inspect running chrome instances was liked very much.
  • Forwarded console.logs was met with praise
  • The keep open + slow mo feature impressed (although it's just puppeteer if we're honest 😉 )
  • Result pdf is neat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant