feat(dmn-js-drd): implement search #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
requested review from
a team,
marstamm and
smbea
and removed request for
a team
barmac
force-pushed
the
implement-search-in-drd
branch
from
a706913 to
f30c2c6
Compare
smbea
suggested changes
Oct 17, 2023
There was a problem hiding this comment.
I think we can add simple tests for the editor actions and bindings specifically, in order to test the full contract
bpmn-io-tasks
bot
added
in progress
barmac
force-pushed
the
implement-search-in-drd
branch
from
f30c2c6 to
aa32eea
Compare
bpmn-io-tasks
bot
added
needs review
smbea
reviewed
Oct 17, 2023
packages/dmn-js-drd/test/spec/features/editor-actions/DrdEditorActionsSpec.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Beatriz Mendes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#1478