Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CHANGELOG): update for v17.0.2 #922

Merged
merged 1 commit into from
Nov 14, 2024
Merged

chore(CHANGELOG): update for v17.0.2 #922

merged 1 commit into from
Nov 14, 2024

Conversation

abdul99ahad
Copy link
Contributor

@abdul99ahad abdul99ahad commented Nov 14, 2024

Proposed Changes

Updated CHANGELOG

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 14, 2024
Comment on lines 9 to 11
## 17.1.0

* `FIX`: formal parameters suggestions are available in real time ([#914](https://github.com/bpmn-io/dmn-js/pull/914))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the only entry is a fix, and the closed issue mentioned a bug, we should release a patch release.
Let's also link to the dmn-js issue instead of pull request if possible: #896
The changelog entries follow git convention of using imperative form, so this should be something like "display updated formal parameters in suggestions"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@abdul99ahad abdul99ahad changed the title chore(CHANGELOG): update for v17.1.0 chore(CHANGELOG): update for v17.0.2 Nov 14, 2024
@barmac
Copy link
Member

barmac commented Nov 14, 2024

Looks good! Let's merge this, and release from main now.

@abdul99ahad abdul99ahad deleted the prepare-17-1-0 branch November 14, 2024 13:54
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 14, 2024
@abdul99ahad abdul99ahad restored the prepare-17-1-0 branch November 14, 2024 13:57
@abdul99ahad abdul99ahad reopened this Nov 14, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 14, 2024
@abdul99ahad abdul99ahad merged commit eeb990e into develop Nov 14, 2024
9 checks passed
@abdul99ahad abdul99ahad deleted the prepare-17-1-0 branch November 14, 2024 13:58
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants