Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove label property on the datetime component #1268

Closed
vsgoulart opened this issue Sep 17, 2024 · 1 comment
Closed

Remove label property on the datetime component #1268

vsgoulart opened this issue Sep 17, 2024 · 1 comment
Assignees
@Skaiir
Labels
spring cleaning Could be cleaned up one day

Comments

@vsgoulart
Copy link
Contributor

What should we do?

Currently we have the label property exported in the datetime component but this property is not used anywhere except on the properties panel with the static value Date time.

We should remove this property and use the existing ones dateLabel and timeLabel

Why should we do it?

To keep the exported schema clean with only relevant data
@vsgoulart vsgoulart added the spring cleaning Could be cleaned up one day label Sep 17, 2024
@vsgoulart vsgoulart mentioned this issue Sep 17, 2024
Open
@nikku nikku added the backlog Queued in backlog label Oct 1, 2024 — with bpmn-io-tasks
Skaiir added a commit that referenced this issue Oct 3, 2024
@Skaiir
fix: do not create a simple label in datetime components
1c94e2c 
Closes #1268
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 3, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Oct 3, 2024
@Skaiir Skaiir mentioned this issue Oct 3, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 3, 2024
Skaiir added a commit that referenced this issue Oct 4, 2024
@Skaiir
fix: do not create a simple label in datetime components
9cb6c1a 
Closes #1268
@Skaiir
Copy link
Contributor

Skaiir commented Oct 4, 2024

Closed via #1292

@Skaiir Skaiir closed this as completed Oct 4, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikku @vsgoulart @Skaiir