Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time form component has the question mark "?" in the placeholder text #1273

Closed
volodymyr-melnykc opened this issue Sep 24, 2024 · 0 comments · Fixed by #1289
Closed

Time form component has the question mark "?" in the placeholder text #1273

volodymyr-melnykc opened this issue Sep 24, 2024 · 0 comments · Fixed by #1289
Assignees
@Skaiir
Labels
bug Something isn't working

Comments

@volodymyr-melnykc
Copy link

volodymyr-melnykc commented Sep 24, 2024 •
edited
Loading

Describe the Bug

A question mark "?" is displayed in the placeholder text of the Time form component.

image

Steps to Reproduce

  1. Open the form editor
  2. Add the Date & time component on the form canvas
  3. Select the "Subtype" as Date & time or Time.
  4. The placeholder text hh:mm ?m is shown.

Expected Behavior

  • The placeholder text hh:mm -- is shown.
@volodymyr-melnykc volodymyr-melnykc added the bug Something isn't working label Sep 24, 2024
@volodymyr-melnykc volodymyr-melnykc changed the title The time form component has the question mark "?" in the placeholder text Time form component has the question mark "?" in the placeholder text Sep 24, 2024
@Skaiir Skaiir self-assigned this Oct 1, 2024
Skaiir added a commit that referenced this issue Oct 3, 2024
@Skaiir
fix: adjust the am/pm time placeholder to hh:mm --
5bbb5b9 
Closes #1273
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 3, 2024
@Skaiir Skaiir mentioned this issue Oct 3, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 3, 2024
Skaiir added a commit that referenced this issue Oct 3, 2024
@Skaiir
fix: adjust the am/pm time placeholder to hh:mm --
8b24d05 
Closes #1273
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Skaiir Skaiir

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: adjust the am/pm time placeholder to hh:mm -- bpmn-io/form-js
2 participants
@Skaiir @volodymyr-melnykc