Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize the properties panel component label getter #1290

Closed
Skaiir opened this issue Oct 3, 2024 · 1 comment · Fixed by #1303
Closed

Parameterize the properties panel component label getter #1290

Skaiir opened this issue Oct 3, 2024 · 1 comment · Fixed by #1303
Assignees
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day

Comments

@Skaiir
Copy link
Contributor

Skaiir commented Oct 3, 2024

Is your feature request related to a problem? Please describe.

We're starting to get quite a few components who's subheading don't quite match the label. While keeping the same default behaviors, I think we should introduce a config at the component label to define how the label is obtained. This is useful to keep our code base nice and clean, but also for custom components which might want to control this property.

Describe the solution you'd like

I think adding a simple getSubheading, or something of the sort, to component.config objects

Describe alternatives you've considered

n/a

Additional context

Somewhat related: #1291

@Skaiir Skaiir added enhancement New feature or request spring cleaning Could be cleaned up one day backlog Queued in backlog labels Oct 3, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 14, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Oct 14, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 14, 2024
@Skaiir Skaiir changed the title [WIP] Parameterize the properties panel component label getter Parameterize the properties panel component label getter Oct 14, 2024
@Skaiir
Copy link
Contributor Author

Skaiir commented Oct 14, 2024

Closed via #1300

@Skaiir Skaiir closed this as completed Oct 14, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spring cleaning Could be cleaned up one day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant