Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate instead of automatically resetting height entries #1034

Merged
merged 1 commit into from
Feb 14, 2024
Merged

fix: validate instead of automatically resetting height entries #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/form-js-editor/src/features/properties-panel/entries/HeightEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,12 @@ function Height(props) {
description,
editField,
field,
id,
defaultValue = 60 // default value for spacer
id
} = props;

const debounce = useService('debounce');

const getValue = (e) => get(field, [ 'height' ], defaultValue);
const getValue = (e) => get(field, [ 'height' ], null);

const setValue = (value, error) => {
if (error) {
Expand Down Expand Up @@ -77,7 +76,7 @@ function Height(props) {
*/
const validate = (value) => {
if (typeof value !== 'number') {
return null;
return 'A number is required.';
}

if (!Number.isInteger(value)) {
Expand Down
1 change: 0 additions & 1 deletion packages/form-js-editor/src/features/properties-panel/entries/IFrameHeightEntry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ export function IFrameHeightEntry(props) {
return [
...HeightEntry({
...props,
defaultValue: 300,
description: 'Height of the container in pixels.',
isDefaultVisible: (field) => field.type === 'iframe'
})
Expand Down
Loading