fix: serialize object table cells using the JSON serializer #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1139
Decided to simply go for JSON serialization here. It's the most permissive approach and also is the easiest to understand where you went wrong (if at all). This changes how arrays are rendered, but the previous way was simply concatenating the contents without spaces which was definitely not "defined behavior", so we don't need to worry about any backwards compatibility issues.
I've considered circular references, they are not a problem as in any case we do a JSON serialization of the entire data during import, which would crash in case of circular object references. Whether we should have something to handle circular references in source data, debatable, but another issue entirely.