-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): Don't clip radio buttons #1261
Conversation
863a4b0
to
df57c9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clipping is intentional for long labels. With this change you can totally break the structure unfortunately. And since it can be driven by variables we don't really want that. I'm not sure if it's possible to properly do clipping but also have the label wrap the checkbox in the DOM.
I think we need to split them, just generally, even if it means adding a nesting node to flexbox them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Skaiir There are some problems with the Carbonization, there's no padding between radio items and the checked state is not working on checkboxes or radio buttons anymore
packages/form-js-viewer/src/render/components/form-fields/Checklist.js
Outdated
Show resolved
Hide resolved
packages/form-js-viewer/src/render/components/form-fields/Checklist.js
Outdated
Show resolved
Hide resolved
packages/form-js-viewer/src/render/components/form-fields/Radio.js
Outdated
Show resolved
Hide resolved
f1866f6
to
7272cfe
Compare
Related to #3688
7272cfe
to
8411455
Compare
Related to #1140
Closes camunda/camunda#19945
form-js
element or visually changes an existing component.