-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add security properties for iFrame #989
Conversation
@Skaiir Didn't @volodymyr-melnykc ask for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Skaiir everything looks fine to me, we just need to check the previous comment I made about the toggle
packages/form-js-viewer/src/render/components/form-fields/IFrame.js
Outdated
Show resolved
Hide resolved
Yeah the PR was made before those comments, sorting this out now. |
798a1ae
to
3756d05
Compare
Made some adjustments. I'm still a bit apprehensive with regards to this configuration here (ignore validation error).
Okay after some heavy reading I'm a little reassured. So, allow-same-origin only really de-sanboxes if the parent and iframe are on the same domain. This would mean that for an XSS attack to occur, it would require something on whatever js embedding domain to already be vulnerable to script injection. Anyways, I am going to rename allow-same-origin's user text from 'Storage and Cookies' to 'Allow same origin'. Because right now it gives the impression that you can't use basic website functionality without this set, which is not true. That way nobody will assume what it does and will have to read into it. |
3756d05
to
5bc1e26
Compare
5bc1e26
to
195727b
Compare
195727b
to
d89a140
Compare
d89a140
to
d89df10
Compare
d89df10
to
3e68d26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #901