Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LeaderSegment.resolve() should not return empty string #114

Open
bertfrees opened this issue Jan 27, 2020 · 1 comment
Open

LeaderSegment.resolve() should not return empty string #114

bertfrees opened this issue Jan 27, 2020 · 1 comment

Comments

@bertfrees
Copy link
Collaborator

LeaderSegment.resolve() and LeaderSegment.peek() currently return the empty string. The exact string that is returns doesn't matter because it is not literally included in the result, however it can influence the translation of the segments around the leader. The simplest and most accurate thing to do is probably to return a single instance of the leader pattern. The length doesn't matter.

@bertfrees
Copy link
Collaborator Author

See mtmse#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant