Uninitialised array in VL53L1_RdDWord

[eugen-vusak]

In function

VL53L1_Error VL53L1_RdDWord(VL53L1_DEV Dev, uint16_t index, uint32_t *data) {
    uint8_t buf[4];
    VL53L1_ReadMulti(Dev, index, (uint8_t *)data, 4);
    *data = (buf[0] << 24) | (buf[1] << 16) | (buf[2] << 8) | buf[3];
    VL53L1_Error Status = VL53L1_ERROR_NONE;
    return Status;
}

I think that instead of

VL53L1_ReadMulti(Dev, index, (uint8_t *)data, 4);

it should be

VL53L1_ReadMulti(Dev, index, (uint8_t *)buf, 4);

because that is only thing that makes sense.

[braincore]

Good find! VL53L1_RdDWord must not be called by anything I've used. How did you discover this?

[eugen-vusak]

I was writing my version of C++ port for VL53L1x API, so I borrowed some of the code and cppcheck pointed this out as warning saying that buf array was uninitialised. But yes this function is not used anywhere in rest of the API.