From 01fd2162ce1d9e8a8eadba0aec0e09923da87131 Mon Sep 17 00:00:00 2001 From: Ed Spencer Date: Thu, 12 Dec 2024 19:22:41 -0500 Subject: [PATCH 1/2] Update EvaluatingChatAssistant.ipynb Make more clear that experimentData was changed to include chat_history --- examples/EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb b/examples/EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb index 73d680e..7694758 100644 --- a/examples/EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb +++ b/examples/EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb @@ -432,6 +432,7 @@ } ], "source": [ + "//NOTE we added chat_history here", "const experimentData = dataset.map((data) => ({\n", " input: { input: data.input, chat_history: data.chat_history },\n", " expected: data.expected,\n", @@ -520,7 +521,7 @@ "source": [ "We update the parameter to the task function to accept both the `input` string and the `chat_history` array and add the `chat_history` into the messages array in the chat completion request, done here using the spread `...` syntax.\n", "\n", - "We also need to update the `experimentData` and `Factual` function parameters to align with these changes." + "Please note that we changed the format of `experimentData`, and the parameters to the `Factual` function to align with these changes." ] }, { From ba29a14023e27d88e1a736c2c8f19f58eb183635 Mon Sep 17 00:00:00 2001 From: Ed Spencer Date: Fri, 13 Dec 2024 15:28:59 -0500 Subject: [PATCH 2/2] PR feedback --- .../EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb b/examples/EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb index 7694758..ef148bb 100644 --- a/examples/EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb +++ b/examples/EvaluatingChatAssistant/EvaluatingChatAssistant.ipynb @@ -432,7 +432,7 @@ } ], "source": [ - "//NOTE we added chat_history here", + "// NOTE we added chat_history here", "const experimentData = dataset.map((data) => ({\n", " input: { input: data.input, chat_history: data.chat_history },\n", " expected: data.expected,\n", @@ -521,7 +521,7 @@ "source": [ "We update the parameter to the task function to accept both the `input` string and the `chat_history` array and add the `chat_history` into the messages array in the chat completion request, done here using the spread `...` syntax.\n", "\n", - "Please note that we changed the format of `experimentData`, and the parameters to the `Factual` function to align with these changes." + "Please note that we changed the format of `experimentData` and the parameters to the `Factual` function to align with these changes." ] }, {