Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-introduce pressure drop calculation based on medium properties #48

Open
marcusfuchs opened this issue Sep 8, 2016 · 2 comments
Open

Comments

@marcusfuchs
Copy link
Collaborator

As discussed in this weeks conference call, we may want to go back from the current pressure drop pre-calculation to the one we had before and instead add a new medium model to the Annex 60 library that better represents water used in district heating. I opened an issue at ibpsa#511 for the new medium model.

In this issue here I suggest to revert the changes introduced by #30. As #30 contains quite a lot of commits, I would opt for quickly pushing a manual code change rather than a real git revert.

bramvdh91 pushed a commit that referenced this issue Sep 8, 2016
Back to old dp calculation, for #48
@bramvdh91
Copy link
Owner

What is the current status of this issue? I think this was solved in #49, but do we have any progress on the dp calculation?

Crazy idea: we could include the heat gains by the friction dissipation in the pipes if we have the design value ;)

@bramvdh91
Copy link
Owner

bramvdh91 commented Apr 4, 2017

Some ToDo's from Carles' comment under #71

  • propagate the HydraulicDiameter parameters (ReC, roughness, fac, allowFlowReversal, ...)
  • dp_nominal is not used anymore. We can remove it or suggest to change HydraulicDiameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants