-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests #74
Comments
In addition, the unit tests that can be done now run into a lot of errors in pedantic mode and mostly fail to simulate. Any help here is welcome :) |
see branch |
Also cleaning up examples in this branch |
@marcusfuchs would you be able to help here? I'm trying to run unit tests on the Validation package, but I keep getting errors that cause the unit tests to fail (such as non-literal value, unspecified initial conditions,...) |
@bramvdh91 You're right, it would be great to get rid of these errors. I hope I find the time to also look into this. |
@marcusfuchs I was able to remove the "non-literal values" by including |
Great! |
We want to test all basic components, hence a call to provide unit tests here.
The total pipe model is already tested in the validation examples, but maybe it is a good idea to add some basic additional tests?
Here's a list of components that would be good to test (we could base this on the existing examples in UseCases):
The text was updated successfully, but these errors were encountered: