Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #74

Open
4 tasks
bramvdh91 opened this issue Apr 12, 2017 · 7 comments
Open
4 tasks

Add unit tests #74

bramvdh91 opened this issue Apr 12, 2017 · 7 comments

Comments

@bramvdh91
Copy link
Owner

We want to test all basic components, hence a call to provide unit tests here.
The total pipe model is already tested in the validation examples, but maybe it is a good idea to add some basic additional tests?
Here's a list of components that would be good to test (we could base this on the existing examples in UseCases):

  • PipeAdiabaticPlugFlow for standstill and reversing flow
  • PipeCore for standstill and reversing flow
  • TimeDelay component
  • HeatLossPipeDelay (some ambiguous naming here too, maybe drop delay?)
@bramvdh91
Copy link
Owner Author

In addition, the unit tests that can be done now run into a lot of errors in pedantic mode and mostly fail to simulate. Any help here is welcome :)

@bramvdh91
Copy link
Owner Author

see branch pipe_issue74_unitTests

@bramvdh91
Copy link
Owner Author

Also cleaning up examples in this branch

@bramvdh91
Copy link
Owner Author

@marcusfuchs would you be able to help here? I'm trying to run unit tests on the Validation package, but I keep getting errors that cause the unit tests to fail (such as non-literal value, unspecified initial conditions,...)

@marcusfuchs
Copy link
Collaborator

@bramvdh91 You're right, it would be great to get rid of these errors. I hope I find the time to also look into this.

@bramvdh91
Copy link
Owner Author

@marcusfuchs I was able to remove the "non-literal values" by including dp(nominal=2) in the instantiation of the HydraulicDiameter res :) For the initial conditions, some more work is needed, but in any case now the Validation unit tests are running without problem.

@marcusfuchs
Copy link
Collaborator

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants