-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a static pipe model for comparison #76
Comments
@GersHub I added the static model to the branch |
@bramvdh91 @GersHub Tin_a = Medium.temperature_phX(
port_a.p,
inStream(port_a.h_outflow),
inStream(port_a.Xi_outflow)); Any objections to changing this to Tin_a = Medium.temperature_phX(
port_a.p,
inStream(port_a.h_outflow),
Medium.X_default); ? |
No if it works on both platform.
Any idea for the origin of the error?
…-----Message d'origine-----
De : "marcusfuchs" <[email protected]>
Envoyé : 04-07-17 21:55
À : "bramvdh91/modelica-ibpsa" <[email protected]>
Cc : "Subscribed" <[email protected]>
Objet : Re: [bramvdh91/modelica-ibpsa] Add a static pipe model for comparison(#76)
@bramvdh91 @GersHub
I'm playing around with JModelica, and in the current implementation of HeatLossPipeStatic I get a type error on
Tin_a = Medium.temperature_phX(
port_a.p,
inStream(port_a.h_outflow),
inStream(port_a.Xi_outflow));Any objections to changing this to
Tin_a = Medium.temperature_phX(
port_a.p,
inStream(port_a.h_outflow),
Medium.X_default);?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Haven't looked too deep into this, but I guess it has something to do with how JModelica and Dymola handle the mass fractions of a medium.
Therefore, JModelica could be correct in returning an empty value of type |
As discussed in the past, it is possible to model static pipe behavior within a model structure similar to the newly developed pipe model. This needs 2 changes
I'll add such a model for comparison and reference.
@GersHub sorry for the long delay in getting to this.
The text was updated successfully, but these errors were encountered: