Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override crypto-js to 4.2.0 #33

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Override crypto-js to 4.2.0 #33

merged 1 commit into from
Nov 13, 2023

Conversation

diracdeltas
Copy link
Contributor

kdenhartog
kdenhartog approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ethereum-address is only using this dependency for sha3 so this override won't impact the code used here.

This seems fine to merge

@tsmartt tsmartt merged commit fa23b32 into master Nov 13, 2023
4 checks passed
@tsmartt tsmartt deleted the fix/cryptojs branch November 13, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmartt tsmartt tsmartt approved these changes

@kdenhartog kdenhartog kdenhartog approved these changes

@jlbyrne jlbyrne Awaiting requested review from jlbyrne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diracdeltas @kdenhartog @tsmartt