Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Post Confirmation Details for Solana Swap Transaction #42516

Closed
3 of 6 tasks
Douglashdaniel opened this issue Nov 26, 2024 · 2 comments · Fixed by brave/brave-core#26820
Closed
3 of 6 tasks

Broken Post Confirmation Details for Solana Swap Transaction #42516

Douglashdaniel opened this issue Nov 26, 2024 · 2 comments · Fixed by brave/brave-core#26820
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.73.x - Release #5

Comments

@Douglashdaniel
Copy link

Description

Solana Swap transactions are displaying broken transaction details on the Post Confirmation panels

Steps to reproduce

  1. Open the Wallet and create a Solana Swap transactions
  2. Confirm the transaction and wait for the Post Confirmation panels to appear.
  3. The Post Confirmation panels are showing missing or broken localization information

Actual result

Image
Image

Expected result

Should show generic information like Swapping on Solana Mainnet Beta and There was an error attempting to swap on Solana Mainnet Beta

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.73.89 Chromium: 131.0.6778.69 (Official Build) (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@Douglashdaniel Douglashdaniel added bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/Yes release-notes/include labels Nov 26, 2024
@Douglashdaniel Douglashdaniel self-assigned this Nov 26, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Nov 26, 2024
This was referenced Nov 26, 2024
Merged
Merged
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Dec 2, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Dec 4, 2024
This was referenced Dec 5, 2024
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Dec 5, 2024

The above requires 1.73.99 or higher for 1.73.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Dec 6, 2024

Verification passed on

Brave 1.73.99 Chromium: 131.0.6778.108 (Official Build) (64-bit)
Revision 273b36438521dd91cbab7a047e6d90deabf59d56
OS Windows 11 Version 23H2 (Build 22631.4460)
  • Verified steps from brave/brave-core#26820
  • Verified Solana Swap/Bridge Transaction Intent description is not broken and shows generic message
42516.mp4

@LaurenWags LaurenWags mentioned this issue Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Status: Done
Milestone
1.73.x - Release #5
Development

Successfully merging a pull request may close this issue.

fix(wallet): Solana Swap Transaction Intent brave/brave-core
4 participants
@kjozwiak @srirambv @Douglashdaniel @brave-builds