-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local state pref to use from Java #16486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
potential-layer-violation-fixes
This PR touches a BUILD.gn file with check_includes=false
label
Dec 28, 2022
AlexeyBarabash
force-pushed
the
android_local_state
branch
4 times, most recently
from
December 29, 2022 18:48
429d2c7
to
188f850
Compare
…tate Java wrapper
- BravePrefServiceBridge.setReferralAndroidFirstRunTimestamp; - BravePrefServiceBridge.setReferralCheckedForPromoCodeFile; - BravePrefServiceBridge.setReferralInitialization; - BravePrefServiceBridge.setReferralPromoCode; - BravePrefServiceBridge.setReferralDownloadId.
AlexeyBarabash
requested review from
samartnik and
SergeyZhukovsky
as code owners
January 4, 2023 14:39
AlexeyBarabash
force-pushed
the
android_local_state
branch
from
January 4, 2023 14:39
83f0761
to
429de76
Compare
SergeyZhukovsky
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
bridiver
reviewed
Oct 6, 2024
return BraveLocalStateJni.get().getPrefService(); | ||
} | ||
|
||
/** Makes local state data be written to the disk asap */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not do this, the actual writing of prefs to disk should be left to the pref service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#27632
Intruduced BraveLocalState class.
Removed methods from BravePrefServiceBridge which were used to access these local_state prefs:
Removed unused Java/JNI methods:
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
New features are not added with this PR. The test plan is required to verify nothing is broken.
I.
brave.p3a.enabled
Share completely private and anonymous product insights about what features are being used by Brave's users.
entry.
4. Go to app menu => Settings => Brave Shields & privacy,
Allow privacy-preserving product diagnostic (P3A)
must be unchecked5. Check
Allow privacy-preserving product diagnostic (P3A)
switch6. Open brave://local-state, the entry should look
II.
brave.stats.reporting_enabled
Automatically send daily usage pings
reporting_enabled
should be falseAutomatically send daily usage pings
must be uncheckedIII.
safetynet.status
According to the code, the Brave Rewards grant should be retreived successfullt to verify it works as before.
IV.
brave.unstoppable_domains.resolve_method
Enabled
resolve_method
nearunstoppable_domains
, it should beEnabled
V.
brave.ens.resolve_method
Enabled
resolve_method
nearens
, it should beEnabled
VI.
brave.sns.resolve_method
Enable Solana Name Service support
=> Enabled, relaunch browserEnabled
resolve_method
nearsns
, it should beEnabled
VII.
brave.ens.offchain_resolve_method
ENS offchain lookup
toEnabled
resolve_method
nearunstoppable_domains
, it should beENS offchain lookup
should still beEnabled