Make it possible to view all commands in Brave, and their shortcuts #16845

fallaciousreasoning · 2023-01-25T03:05:54Z

This PR makes it possible to view the available commands in Brave on the brave://commands page when the brave://flags/#brave-commands flag is on.

app/command_utils.cc

brave-builds · 2023-02-07T04:00:49Z

A Storybook has been deployed to preview UI for the latest push

browser/about_flags.cc

components/resources/BUILD.gn

test/BUILD.gn

resources/resource_ids.spec

app/command_utils.cc

app/command_utils.h

app/command_utils.cc

browser/ui/webui/commands_ui.cc

browser/ui/webui/commands_ui.h

components/commands/browser/resources/commands.html

components/commands/browser/resources/utils/match.ts

sangwoo108 · 2023-02-07T06:02:36Z

components/commands/common/key_names.h

+std::string GetKeyName(ui::KeyboardCode code);
+std::vector<std::string> GetModifierName(ui::KeyEventFlags flags);


I'm wondering if we can use Accelerator::GetShortcutTexts() instead of managing all the characters. There could have problems like

We might have to split the shorcut text with +

We might have to distinguish which one is modifier - maybe we could consider names longer than 1 as modifiers. or hardcode modifiers but hope this could be fewer than all characters

I'm kind of prefer this version, as there're tons of characters, and we might need to consider localization per contries's keyboard layout when we manage them by ourselves 😹 But it's totally your call!

I just had a play with changing it over, and it's quite a bit worse - there are a bunch of missing keys, and a bunch of keys which are displayed wrong:

All function keys are missing

Special keys are mislabelled (Keyboard back/forward is Arrow left/right)

Cmd modifier doesn't seem to show up on Linux

I think longer term it might be good to try and fix the GetShortcutsText function (maybe upstream...) but for now this produces much better results :'(

(maybe upstream...)

Yeah, I don't want you to go through that tough way haha. Maybe we can wrap the GetShortcutText() and fix up some of the results later on.

app/command_utils.cc

components/commands/browser/resources/commands.html

brave-builds · 2023-02-07T23:33:21Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-02-15T01:30:09Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-02-15T03:45:15Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-02-15T23:29:26Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-02-16T21:35:02Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-02-17T00:38:44Z

A Storybook has been deployed to preview UI for the latest push

fallaciousreasoning · 2023-02-17T02:14:37Z

@rillian I accidentally committed Cargo.lock, which was being modified when I was building. I've reverted the change, mind dismissing the review (or reviewing)

brave-builds · 2023-02-17T03:08:29Z

A Storybook has been deployed to preview UI for the latest push

antonok-edm · 2023-02-17T19:50:11Z

@fallaciousreasoning dismissed rust-deps-reviewers for you 😄

brave-builds · 2023-02-19T20:55:00Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-02-20T03:56:24Z

A Storybook has been deployed to preview UI for the latest push

accelerators

brave-builds · 2023-02-20T20:07:15Z

A Storybook has been deployed to preview UI for the latest push

aguscruiz · 2023-03-01T12:05:03Z

@fallaciousreasoning Worked on the design here, it's a simple restyling for now to just use Brave's flavors:
https://www.figma.com/file/tLXWGCpNoiJxDZDdpfordj/Desktop-Settings?node-id=3617%3A77370&t=edamn8UoehFfaggp-1

emerick · 2024-03-08T21:55:06Z

app/BUILD.gn

+source_set("browser_tests") {
+  testonly = true
+
+  if (!is_android && !is_ios) {


Sorry, I realize this is an old PR, but I'm trying to understand this part. Is it intentional to only build this browser test on desktop? Unless I'm not understanding, this browser test is definitely meant to run on Android at least.

Yeah, the code doesn't run on Android/iOS at all, so the test only runs on desktop too - it should probably have its own buildflag.

OK, I think you're saying that command_utils_browsertest isn't supported on Android. But this change also prevents brave_main_delegate_browsertest from running on Android (even though it was previously supported there). Maybe I'm not understanding though?

I have a PR that's addressing this, just trying to figure out if it was intentional. :-)

That probably was not intentional 😆

OK, no problem! I'm moving the feature tests into a unit test and also making them run on Android in this PR: #22516.

fallaciousreasoning requested a review from a team as a code owner January 25, 2023 03:05

github-actions bot assigned fallaciousreasoning Jan 25, 2023

github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Jan 25, 2023

goodov reviewed Jan 27, 2023

View reviewed changes

app/command_utils.cc Outdated Show resolved Hide resolved

fallaciousreasoning marked this pull request as draft January 29, 2023 21:02

fallaciousreasoning force-pushed the shortcuts-list branch 2 times, most recently from 723bb2e to 23b415f Compare February 7, 2023 02:10

fallaciousreasoning marked this pull request as ready for review February 7, 2023 02:25

fallaciousreasoning requested review from sangwoo108 and simonhong February 7, 2023 02:25

fallaciousreasoning force-pushed the shortcuts-list branch from 23b415f to f2b5a87 Compare February 7, 2023 02:49

simonhong reviewed Feb 7, 2023

View reviewed changes

browser/about_flags.cc Outdated Show resolved Hide resolved

components/resources/BUILD.gn Outdated Show resolved Hide resolved

test/BUILD.gn Outdated Show resolved Hide resolved

resources/resource_ids.spec Outdated Show resolved Hide resolved

goodov reviewed Feb 7, 2023

View reviewed changes

app/command_utils.cc Outdated Show resolved Hide resolved

sangwoo108 reviewed Feb 7, 2023

View reviewed changes

app/command_utils.cc Outdated Show resolved Hide resolved

fallaciousreasoning requested review from sangwoo108 and simonhong February 7, 2023 22:44

github-actions bot reviewed Feb 7, 2023

View reviewed changes

components/commands/browser/resources/commands.html Show resolved Hide resolved

github-actions bot added the needs-security-review label Feb 7, 2023

github-actions bot assigned fmarier and thypon Feb 7, 2023

thypon removed the needs-security-review label Feb 7, 2023

thypon unassigned fmarier and thypon Feb 7, 2023

github-actions bot added the needs-security-review label Feb 7, 2023

github-actions bot assigned fmarier and thypon Feb 7, 2023

fallaciousreasoning requested a review from a team as a code owner February 15, 2023 00:46

fallaciousreasoning force-pushed the shortcuts-list branch from 67c46b1 to a147bcc Compare February 15, 2023 03:07

fallaciousreasoning force-pushed the shortcuts-list branch from 6aefebc to 3f2fdb4 Compare February 16, 2023 23:57

fallaciousreasoning force-pushed the shortcuts-list branch from 3f2fdb4 to b5d6f44 Compare February 17, 2023 02:12

fallaciousreasoning requested a review from rillian February 17, 2023 02:13

antonok-edm removed the request for review from a team February 17, 2023 19:49

fallaciousreasoning force-pushed the shortcuts-list branch 2 times, most recently from f479497 to 3a18b17 Compare February 19, 2023 20:10

fallaciousreasoning force-pushed the shortcuts-list branch from 3a18b17 to 880aa41 Compare February 20, 2023 03:14

fallaciousreasoning enabled auto-merge (squash) February 20, 2023 03:14

fallaciousreasoning disabled auto-merge February 20, 2023 05:11

Add a WebUI page where it's possible to view all commands and their

1b8906a

accelerators

fallaciousreasoning force-pushed the shortcuts-list branch from 880aa41 to 1b8906a Compare February 20, 2023 19:05

fallaciousreasoning merged commit 48af20f into master Feb 20, 2023

fallaciousreasoning deleted the shortcuts-list branch February 20, 2023 23:35

github-actions bot added this to the 1.50.x - Nightly milestone Feb 20, 2023

LaurenWags mentioned this pull request Mar 14, 2023

Make Keyboard Shortcuts more Discoverable brave/brave-browser#28329

Closed

emerick reviewed Mar 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make it possible to view all commands in Brave, and their shortcuts #16845

Make it possible to view all commands in Brave, and their shortcuts #16845

fallaciousreasoning commented Jan 25, 2023 •

edited

Loading

brave-builds commented Feb 7, 2023

sangwoo108 Feb 7, 2023 •

edited

Loading

fallaciousreasoning Feb 7, 2023 •

edited

Loading

sangwoo108 Feb 8, 2023 •

edited

Loading

brave-builds commented Feb 7, 2023

brave-builds commented Feb 15, 2023

brave-builds commented Feb 15, 2023

brave-builds commented Feb 15, 2023

brave-builds commented Feb 16, 2023

brave-builds commented Feb 17, 2023

fallaciousreasoning commented Feb 17, 2023

brave-builds commented Feb 17, 2023

antonok-edm commented Feb 17, 2023

brave-builds commented Feb 19, 2023

brave-builds commented Feb 20, 2023

brave-builds commented Feb 20, 2023

aguscruiz commented Mar 1, 2023

emerick Mar 8, 2024

fallaciousreasoning Mar 10, 2024

emerick Mar 11, 2024

emerick Mar 11, 2024

fallaciousreasoning Mar 11, 2024

emerick Mar 11, 2024

		std::string GetKeyName(ui::KeyboardCode code);
		std::vector<std::string> GetModifierName(ui::KeyEventFlags flags);

Make it possible to view all commands in Brave, and their shortcuts #16845

Make it possible to view all commands in Brave, and their shortcuts #16845

Conversation

fallaciousreasoning commented Jan 25, 2023 • edited Loading

brave-builds commented Feb 7, 2023

sangwoo108 Feb 7, 2023 • edited Loading

Choose a reason for hiding this comment

fallaciousreasoning Feb 7, 2023 • edited Loading

Choose a reason for hiding this comment

sangwoo108 Feb 8, 2023 • edited Loading

Choose a reason for hiding this comment

brave-builds commented Feb 7, 2023

brave-builds commented Feb 15, 2023

brave-builds commented Feb 15, 2023

brave-builds commented Feb 15, 2023

brave-builds commented Feb 16, 2023

brave-builds commented Feb 17, 2023

fallaciousreasoning commented Feb 17, 2023

brave-builds commented Feb 17, 2023

antonok-edm commented Feb 17, 2023

brave-builds commented Feb 19, 2023

brave-builds commented Feb 20, 2023

brave-builds commented Feb 20, 2023

aguscruiz commented Mar 1, 2023

emerick Mar 8, 2024

Choose a reason for hiding this comment

fallaciousreasoning Mar 10, 2024

Choose a reason for hiding this comment

emerick Mar 11, 2024

Choose a reason for hiding this comment

emerick Mar 11, 2024

Choose a reason for hiding this comment

fallaciousreasoning Mar 11, 2024

Choose a reason for hiding this comment

emerick Mar 11, 2024

Choose a reason for hiding this comment

fallaciousreasoning commented Jan 25, 2023 •

edited

Loading

sangwoo108 Feb 7, 2023 •

edited

Loading

fallaciousreasoning Feb 7, 2023 •

edited

Loading

sangwoo108 Feb 8, 2023 •

edited

Loading