Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DanglingPtr] Enable detector for Mac builds #26787

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Nov 27, 2024

This is a follow up in the task of having the dangling pointer being set to the upstream default for MacOS.

Resolves brave/brave-browser#41956

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Chromium major version is behind target branch (131.0.6778.85 vs 132.0.6834.15). Please rebase.

@github-actions github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Dec 2, 2024
This is a follow up in the task of having the dangling pointer being set
to the upstream default for MacOS.

A few cases of `DanglingUntriaged` had to be introduced in order to
satisfy a few broken tests.

Resolves brave/brave-browser#41956
@cdesouza-chromium cdesouza-chromium force-pushed the enable-dangling-ptr-checks-on-mac branch from cd62f76 to ee248da Compare December 4, 2024 04:41
@github-actions github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Dec 4, 2024
@cdesouza-chromium cdesouza-chromium marked this pull request as ready for review December 4, 2024 04:42
@cdesouza-chromium cdesouza-chromium requested a review from a team as a code owner December 4, 2024 04:42
@cdesouza-chromium cdesouza-chromium merged commit 40a35e1 into master Dec 4, 2024
18 checks passed
@cdesouza-chromium cdesouza-chromium deleted the enable-dangling-ptr-checks-on-mac branch December 4, 2024 13:45
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 4, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable dangling pointer detection on Mac
3 participants