Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shardtree crate #26966

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Add shardtree crate #26966

merged 3 commits into from
Dec 13, 2024

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Dec 10, 2024

// Reopened #26474
Resolves brave/brave-browser#40408

Previous pr : #25092
Audit : https://github.com/brave/reviews/issues/1724
zcash_client_backend audit: https://github.com/brave/reviews/issues/1799

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) feature/web3/wallet feature/web3/wallet/core labels Dec 10, 2024
@cypt4 cypt4 force-pushed the shard_crate_impl_1 branch from 9dbf184 to ca9c227 Compare December 10, 2024 20:08
@cypt4 cypt4 marked this pull request as ready for review December 10, 2024 20:08
@cypt4 cypt4 requested review from a team, fmarier and bridiver as code owners December 10, 2024 20:08
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script/brave_license_helper.py changes 👍

Copy link
Collaborator

@supermassive supermassive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wallet core lgtm

@cypt4 cypt4 force-pushed the shard_crate_impl_1 branch 2 times, most recently from 2a88297 to 6830258 Compare December 11, 2024 14:31
@@ -0,0 +1,383 @@
# This file is automatically @generated by Cargo.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should not be any changes to bitflags here, where did this come from?

@cypt4 cypt4 force-pushed the shard_crate_impl_1 branch from b529384 to bdbbab7 Compare December 12, 2024 19:47
@cypt4 cypt4 merged commit d6f3c15 into master Dec 13, 2024
20 checks passed
@cypt4 cypt4 deleted the shard_crate_impl_1 branch December 13, 2024 12:18
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Dec 13, 2024
@brave-builds
Copy link
Collaborator

Released in v1.75.100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ZCash] Add shardtree crate
5 participants