-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmio.jl is using incorrect declarations #33
Comments
Ah yeah, I think there's at least one more I still have wrong in there. As far as I understand If you have any pointers for which calls still have errors and what, that would be much appreciated -- but no worries if not; I know you have important things to do! |
Oh, maybe
|
A few I noticed specifically: incorrect attributes (e.g. nocapture on putc), incorrect ABI (printf is varargs, ftell may return either i64 or i64* depending on the platform ABI, fputc takes an |
Thanks! |
#34 may (?) be enough to fix the pkgeval failures for now, but I'll leave this open until I get a chance to try switching to |
It looks like many of the llvmcalls have incorrect definitions, atributes, types, ABIs, or other errors. These seem like they really should be using
@ccall
instead to let Julia handle those issues. I noticed this because it crashed in PkgEval with an LLVM verifier error.The text was updated successfully, but these errors were encountered: