-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Representation of the condition #10
Comments
Hi Masashi! To be honest this is just a minor personal taste thing, basically an aesthetic choice. I'd be surprised if it matters in practice.
The 9D representation + SVD also requires a little bit less code. |
Thank you so much! Fourier encoding seems very interesting, thanks for sharing the paper. By the way, Eq.(7) in the paper seems wrong if I don't misunderstand. I think |
You're totally right! I'll fix it. |
Hello, first I appreciate your great work.
I have a minor question about the representation of the conditions.
In prior works like EgoEgo, the 6D representation is adopted for the rotation matrix, and the entire matrix with translation (3x4) is represented in a vector of 9 dimensions (6+3).
Is there any specific reason that you didn't follow this, and adopted all elements of the entire matrix concatenated with the Fourier encoded of the same matrix?
Thanks in advance.
The text was updated successfully, but these errors were encountered: