Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade logging from INFO to DEBUG or TRACE #4

Open
whoschek opened this issue May 9, 2012 · 4 comments
Open

downgrade logging from INFO to DEBUG or TRACE #4

whoschek opened this issue May 9, 2012 · 4 comments

Comments

@whoschek
Copy link

whoschek commented May 9, 2012

Thanks for such a handy library - very useful!

The default log level in logging libs such as logback and log4j is INFO. This implies that by default the logger.info() calls in ConfigurationObjectFactory generate tons of distracting log messages on output. It seems to me folks only want to see those message only in debug or trace mode, and not by default. Having to switch this off manually (ala opt out) seems counter intuitive to me.

@hgschmie
Copy link
Collaborator

hgschmie commented May 9, 2012

Choosing INFO was a conscious choice because it ensures that the information required for debugging a problem usually was caught in the log file. Not logging the config settings makes post mortem debugging harder.

@whoschek
Copy link
Author

I think that's what the DEBUG level is intended for, conceptually. If all third party libs would log.info() in debug related places there'd be a sea of distractions in everyone's log files.

Anyway, I can manually work around it. Just thought I'd mention it.

@cowtowncoder
Copy link
Collaborator

I don't think standard processing should cause any logging: if and when configuration values are to be called, calling application should request those to be logged in my opinion, not just expect them to be produced by side effect. If there are any errors, failures or possible conflicts, those are different matter.

Although I guess I can see the optional need to trace through assignment process wrt defaults, beyond ability to list final results.

@brianm
Copy link
Owner

brianm commented Mar 15, 2013

While I agree that standard processing should not be noisy, particularly from libraries, I have needed the config output on occasions :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants