Block parameters for Parser.new and Encoder.new #139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just wanted to sprinkle some syntactic sugar on the
Parser
andEncoder
classes. Whereas now you would have to writeand
this branch allows you to write
and
While I was at it, I
on_progress_callback
practically uselessThe bug occurs because
Encoder#encode
takes a block parameter which setson_progress_callback
in the background. However, later on the block is called directly instead of referring to theon_progress_callback
. This means that settingon_progress_callback
before callingencode
had no effect. This probably went unnoticed because there was no spec for that case but there is now. Check out padde@9ab456e.Please comment on my branch and even if you don't like the block parameters, consider cherry-picking the other fixes.
Cheers