Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader should fail quickly on error #90

Open
jcross-linkup opened this issue Mar 3, 2018 · 0 comments
Open

Loader should fail quickly on error #90

jcross-linkup opened this issue Mar 3, 2018 · 0 comments

Comments

@jcross-linkup
Copy link

While using the loader, we noticed that a fatal failure would occur on one executor thread, but it would take quite a while for the entire program to exit. This is likely due to the res.get() blocking until the future has a result. Depending on the order of the futures and when they return, a failed thread may not return its result until after some successful threads complete. Since the user probably cares that a fatal error has occurred and would like to take corrective action, it makes sense to check on the threads occasionally and detect failures early. Once a failure is detected, the program should exit non-0.

We submitted a PR with the necessary changes: #89
Note that this PR also includes the commit from #88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant